search

golemfactory / golem-core-python

GNU General Public License v3.0
3 stars 2 forks source link

Add AddMidAgreementPayments negotiator #131

Closed lucekdudek closed 7 months ago

lucekdudek commented 8 months ago

one thought -> instead of testing the whole MidAgreentPaymentsNegotiator class, we could test just the _calculate_new_value_proposition method -> it would make the tests simpler and easier to understand...

I am against testing of private methods. Now it is easy to refactor implementation details of the MidAgreentPaymentsNegotiator (e.g. rearrange private methods)

IMO Current test are simple only the number of parameters makes them hard to comprehend

shadeofblue commented 8 months ago

I am against testing of private methods.

:woman_shrugging: ... I have no such reservations but okay :+1: