Short makefile - Githubissues

golemfactory / golem-crowdfunding

Golem token and crowdfunding contracts

GNU General Public License v3.0

78 stars 27 forks source link

Short makefile #81

Closed paulperegud closed 6 years ago

paulperegud commented 7 years ago

split contract files: one contract - one file
automatically collect contract file names in Makefile
use solc -o instead of grep/awk

EDIT: To reviewers: this PR is easier to review commit by commit since some commits move code, and other change it.

subtly commented 7 years ago

Guessing this will see a lot of conflicts before/after merging. Would it be possible and/or easier to rename files in a follow-up PR?

paulperegud commented 7 years ago

Whole point of renaming and splitting files was to enable following Make pattern target:

$(BUILDDIR)/%.bin   $(BUILDDIR)/%.abi: contracts/%.sol
        $(SOLC) $(SOLCFLAGS) $^

When solc is producing GolemNetworkToken.abi from Token.sol, Make does not know if two are related in any way. So there are only two options: renaming or explicit rules. This PR mostly consists of removing explicit rules and renaming.