golemfactory / golem-messages

shared module for formatting and parsing messages (Golem & Concent)

GNU General Public License v3.0

2 stars 8 forks source link

tasks.CannotComputeTask.REASON.CannotTakeWork #364

Closed jiivan closed 4 years ago

jiivan commented 4 years ago

New reason for CannotComputeTask message

claassistantio commented 4 years ago

All committers have signed the CLA.

codecov-io commented 4 years ago

Codecov Report

Merging #364 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   96.87%   96.87%   +<.01%     
==========================================
  Files          57       57              
  Lines        3936     3937       +1     
==========================================
+ Hits         3813     3814       +1     
  Misses        123      123

maaktweluit commented 4 years ago

This new reason looks a lot like OfferCancelled, what is the difference?

jiivan commented 4 years ago

@maaktweluit it's meant to be used here: https://github.com/golemfactory/golem/blob/5550f5b0d5d30fb414526280685ed8e78acfab20/golem/task/tasksession.py#L700-L702

which is triggered here: https://github.com/golemfactory/golem/blob/5550f5b0d5d30fb414526280685ed8e78acfab20/golem/task/taskserver.py#L535-L540