Open lucekdudek opened 1 year ago
what I tried:
1) use multiprocessing instead of threading to alleviate the issue with the event loop threads - no success - either with the new version or after a fallback to the current one...
2) tried a more direct approach
Request
, Response
still - no dice...
General conclusions after trying to debug why the above approaches didn't work:
Probe
class, which in turn depends on the particular configuration of the Docker containers in the image, plus, it cooperates with an nginx server in those containers ... the way forward as I see it:
mitmproxy
and make its usage more straightforward so that it can be tested separately - possibly unit-tested
Current version of
mitmproxy
result ingoth
capping dependency ofclick
at<=8
. Click is a dependency used in othergolemfactory
python project which makes it hard to usegoth
and newest version of other dependencies at the same time.There ware bigger changes made in mitmproxy update from
^6
to^8
. Changes that we know impact goth:mitmproxy.tools.main
stoped usingadd_signal_handler
and goth uses this costruction to use mitmproxy:mitmproxy.http.HTTPRequest
andmitmproxy.http.HTTPResponse
were renamed toRequest
andResponse
What needs to be done:
mitmproxy
so it supportsclick>=8
(note:mitmproxy=^9
requirespython>=3.9
therefor bump to^8
as for now) - this will refactoring of goth, usingpoe checks_typing
can point some red flags in the code base as starting point.