search

golemfactory / gumpi

MPI on Golem Unlimited PoC
GNU Affero General Public License v3.0
2 stars 3 forks source link

Add an option to disable closing the sessions #26

Closed marmistrz closed 5 years ago

mplebanski commented 5 years ago

I understand that this is simply a golem-unlimited thing you wanted to add in gumpi to ease up debugging, right?

marmistrz commented 5 years ago

@mplebanski no. To interact with GU we need to create a HubSession and a ProviderSession. All of the requests happen in the context of a session. When we're done, we close the sessions to allow GU to free resources and clean up the session artifacts, including the image directory.

Unfortunately, if GU cleans up all the artifacts, we can't really investigate any errors happening during the execution after it fails.

marmistrz commented 5 years ago

@mplebanski committing your change dismissed the review, can you click +1 once again?