Move gumpi to gu-client

marmistrz commented 5 years ago

Closes #3, closes #7, closes #14, closes #22, closes #28 The PR will be squash-merged.

Issues to be created after merging:

[enhancement] During upload, read the file as an asynchronous stream (don't read the whole file into memory)
[needs-gu-changes] The display of execution error logs is awful
- it's actually a GU issue, the REST API returns a flat string with all the data
[refactor] move failure_ext and async_ctrlc into separate crates, publish them on crates.io
[refactor/enhancement] use pseudo-RAII AsyncRelease from gu-actix (remove into_inner)
[enhancement] Warn about usused provider filters (probably some of the nodes have gone offline or a typo)

marmistrz commented 5 years ago

@mplebanski @kubkon (one of you) please review the change in a usual way. Additionally, @filipgolem, please review the change and see if I use your API in a correct (and ergonomic) way.

mplebanski commented 5 years ago

@kubkon @marmistrz Since I'm no rust expert and reading actix based logic confuses me (control flow is not clear to me) I suggest that next time @kubkon will give you rust related tips (to grow your rust skill etc.) and I will leave comments regarding readability and general code feel.

golemfactory / gumpi

Move gumpi to gu-client #40