search

golemfactory / ray-on-golem

GNU General Public License v3.0
6 stars 4 forks source link

specifying `subnet_tag` does not override `priority_head_subnet_tag` #205

Open shadeofblue opened 8 months ago

shadeofblue commented 8 months ago

The way I see it, when a user (Ray on Golem developer in this case) specifies any subnet_tag, it's pretty obvious that they want to run their ray requestor against a specific set of provider nodes and none other...

Therefore, intuition tells me that any nodes that are selected as ray instances for the user, should only come from that explicitly named subnet tag.

Actual result: Despite some specific subnet tag being specified in the cluster definition file, ray-on-golem still uses ray-on-golem-heads to select nodes for the Ray's head node.

To achieve the expected result, one needs to provide both subnet_tag and priority_head_subnet_tag...

Expected result: When a user specifies the subnet_tag in my cluster definition file, that selection should also override the priority_head_subnet_tag and all of users' nodes should be selected from the given network.

mateuszsrebrny commented 8 months ago

I am not sure if I agree - this is not intended for external users, therefore I don't see it being a problem that devs need to add both properties. Let's talk at some point :)

mateuszsrebrny commented 8 months ago

@approxit says that the subnet override golem-cluster.override.5-subnet.yaml is having both - so this shouldn't be misleading.

Leaving as a backburner if someone ever wants to fix it :)