golemfactory / ray-on-golem

GNU General Public License v3.0
6 stars 4 forks source link

yagna version conflict when installing ray-on-golem #260

Closed krunch3r76 closed 2 weeks ago

krunch3r76 commented 3 weeks ago

Bug Report: yagna version conflict when installing ray-on-golem

Version: 0.12.1
Environment: Ubuntu 20.04 Affected Executable: <environment>/bin/yagna

Problem Description:

Installing the ray-on-golem pip package in a clean virtual environment installs an outdated version of yagna (0.12.1) to the path, causing both yagna and ray-on-golem to fail to start.

Currently, the ray-on-golem package installs and runs yagna version 0.15.2, which crashes with the following error:

Caused by:
    VersionMissing(20240301000000)
[2024-08-29T17:43:24.985-0700 INFO  ya_service_bus::connection] stopped connection to gsb
Error: VersionMissing(20240301000000), /home/runner/.cargo/git/checkouts/erc20_payment_lib-fffa785e9cf776f9/0304f7f/crates/erc20_payment_lib_common/src/db/connection.rs:57:43

Running yagna 0.16.0 (the most recent version) in a separate process prevents this crash, indicating that the issue is related to the older yagna version being installed.

Steps to Reproduce:

  1. Set up a clean virtual environment.
  2. Install the ray-on-golem package using pip.
  3. Download golem-cluster.yaml.
  4. Attempt to start ray-on-golem via **ray up golem-cluster.yaml --yes** and observe the crash.

Proposed Solution:

Please consider releasing a patch for ray-on-golem that updates yagna to the latest stable version (0.16.0) to prevent this issue.

Attachments: webserver_failure yagna.log webserver_debug.log

Thank you for your attention to this matter.

krunch3r76 commented 2 weeks ago

i am closing the issue because on a clean install of yagna requestor, despite the version differences, this issue is not reproducible (as by the steps listed).

mateuszsrebrny commented 1 week ago

The issue was that ray-on-golem was installing yagna 0.15. It is easily upgradable to yagna 0.16, but not the other way around. So, when you already had yagna 0.16, ray-on-golem pulled 0.15 and couldn't use the datadir.

Since ray-on-golem 0.13.0 yagna 0.16 is used :)