golemfactory / task-api

GNU General Public License v3.0
6 stars 2 forks source link

Golem infrastructure properties in CreateTaskReply #56

Closed mfranciszkiewicz closed 5 years ago

mfranciszkiewicz commented 5 years ago

In the review please include your opinion on:

mfranciszkiewicz commented 5 years ago

I've limited the scope of available properties.

@maaktweluit Strongly typed as in the pb message or a separate dataclass? For messages, you cannot directly assign properties which are messages and have to use the CopyFrom method. E.g. CreateTaskReply.inf_requirements.CopyFrom(inf)

mfranciszkiewicz commented 5 years ago

I've introduced the requested changes. It's taking substantially too much effort to introduce 1 extra returned value.

@Wiezzel @maaktweluit Please re-review.