Closed mfranciszkiewicz closed 5 years ago
I've limited the scope of available properties.
@maaktweluit Strongly typed as in the pb message or a separate dataclass? For messages, you cannot directly assign properties which are messages and have to use the CopyFrom
method. E.g. CreateTaskReply.inf_requirements.CopyFrom(inf)
I've introduced the requested changes. It's taking substantially too much effort to introduce 1 extra returned value.
@Wiezzel @maaktweluit Please re-review.
CreateTaskReply
In the review please include your opinion on:
Infrastructure
protobuf message (bad UX wise) The interface could require anInfrastructure
dataclass instead. In messages we would transfer theInfrastructure
as a JSON object. Doubling the message in dataclasses seems to be an overkill.