create a simple yapapi example that passes an environment variable in a `run` command - Githubissues

golemfactory / yapapi

Python high-level API for Golem.

https://yapapi.readthedocs.io/en/stable/

GNU Lesser General Public License v3.0

48 stars 23 forks source link

create a simple yapapi example that passes an environment variable in a `run` command #1071

Closed shadeofblue closed 1 year ago

shadeofblue commented 1 year ago

user stories:

as a Golem creator, I'd like to know how I can pass environment variables to commands executed on the provider
as an SDK team member, I'd like to confirm or deny the thesis: environment variables support works correctly

implementation details:

use the env argument: https://github.com/golemfactory/yapapi/blob/master/yapapi/script/__init__.py#L154
run e.g. /bin/sh -c set and check its output to verify that the command indeed sees the variable

outcomes:

a new example in yapapi/examples folder which show users a way to set environment variables
verify the relevant functionality works in yagna (vm runtime) -> as mentioned in https://github.com/golemfactory/yapapi/issues/1071#issuecomment-1352956927 it possibly doesn't

johny-b commented 1 year ago

Just FYI, this just doesn't work for a while already:

https://github.com/golemfactory/yapapi/issues/630

approxit commented 1 year ago

Example was created on branch https://github.com/golemfactory/yapapi/tree/1071-create-a-simple-yapapi-example-that-passes-an-environment-variable-in-a-run-command. Env variable is not picked up by yagna. See golemfactory/yagna#2448.