golemfactory / yapapi

Python high-level API for Golem.
https://yapapi.readthedocs.io/en/stable/
GNU Lesser General Public License v3.0
48 stars 23 forks source link

Unified task runner scripts #1086

Closed approxit closed 1 year ago

approxit commented 1 year ago

Bucke up folks, massive diff is comming!

What I've done:

Changes are mostly related to formatting or small fixes such as specifying exception types in except blocks, changing == to is for None values, etc.

shadeofblue commented 1 year ago

hmm, given that we don't treat the examples as modules but rather self-contained scripts, I'm unsure why we'd need __init__ files in there... ?

approxit commented 1 year ago

Regarding __init__.py in examples and tests, I've commented at the very begining that it was added to satisfy mypy, because it encounter errors about loading files without __init__.py. I could reconfigure mypy to check specific list of directories, instead of whole codebase.

Regarding property docs - change was made to satisfy pydocstyle - should we fight with this?