golemfactory / yapapi

Python high-level API for Golem.
https://yapapi.readthedocs.io/en/stable/
GNU Lesser General Public License v3.0
48 stars 23 forks source link

AgreementsPool.on_agreement_terminated is never called #893

Open johny-b opened 2 years ago

johny-b commented 2 years ago

There's a method:

    async def on_agreement_terminated(self, agr_id: str, reason: dict) -> None:
        """Reacts to agreement termination event

        Should be called when AgreementTerminated event is received.
        """
        ...

that does some things, but is not called from anywhere. It should either be removed, or used (it says it "should be called", but it's hard to trust the docstring of an abandoned method;p).

shadeofblue commented 2 years ago

rather than removing it, I'd have it called when it should