Implement left factoring

golems / motion-grammar-kit

Formal Language Tools for Robots

BSD 2-Clause "Simplified" License

13 stars 5 forks source link

Closed Tarrasch closed 11 years ago

Tarrasch commented 11 years ago

I've done my best to write clean code and test it to a reasonable extent. Hopefully I haven't made to many beginners mistakes...

Tarrasch commented 11 years ago

I updated my patch. It's still not using a trie yet but you might still have general feedback.

Tarrasch commented 11 years ago

Updated it again.

ndantam commented 11 years ago

On 02/28/2013 04:39 PM, Arash Rouhani wrote:

Updated it again.

I think this is looking better.

Few comments, mostly on style

'|epsilon| should probably be :epsilon
You should be able to do the final SORT with only a PREDICATE function, rather than a separate :KEY function
Adding some DESTRUCTURING-BINDs to #'BUILD would probably make it easier to follow
Since you have a few different local functions, more descriptive names would be nice
I'd just inline #'HELPER since it's short and only called once

Tarrasch commented 11 years ago

Making up descriptive names is the hardest part of programming. :)

Nevertheless, I did my best and I fixed everything you commented on.

ndantam commented 11 years ago

On 02/28/2013 07:56 PM, Arash Rouhani wrote:

Making up descriptive names is the hardest part of programming. :)

Nevertheless, I did my best and I fixed everything you commented on.

Looks good. I merged and refactored a bit.