Closed zogot closed 1 year ago
@alko89 Yep I think that might have been it.
I'm guessing version 3.0 is Nest 9 only then? Perhaps that needs to be defined in the CHANGELOG? And if so, could we get #482 backmerged into the 2.x.x line?
As my nestjs-rabbitmq now has node_modules of @golevelup/nestjs-modules 0.6.1 which https://github.com/golevelup/nestjs/blob/master/packages/modules/package.json#L39 has a peerDep on @nestjs/common 9.x
Specifically point at
"@golevelup/nestjs-rabbitmq": "^2.4.0",
Still suffers from the issue I described in the main issue though, so I think its 2 parts.
3.X depends on Nest 9 dependencies 2.X still has something not correct with the logger
Oh, I still see the sub node_modules, so looks like Nest 9 is set as peer dependency before the 3.X version
Issue is in 2.4.1 and up. Could we get version 2 to stay with Nest 8 and version 3 to go with Nest 9?
I guess one solution would be to have both nest 8 and 9 as peer dependencies. The only real breaking change in v9 were unit tests, so it should (theoretically) work with both.
I wouldn't backport these features to later versions though and I don't think versioning works like that in this project. But I'm not a maintainer and it works for me :)
Versions:
Something still isn't quite right with the logs. When I do this:
I still get logs from RabbitMQModule:
and nothing further.
I am suspecting its to do with the new logger instances created here but I haven't had the chance currently to put into real testing.
because the official recommended ways to replace the logger just dont work with the latest changes:
Do you think that it can just be changed to how all the other modules do it?
I don't use all of those, but none of them require defining a custom logger in their arguments for it to work correctly with overriding your own logger.