golevelup / nestjs

A collection of badass modules and utilities to help you level up your NestJS applications 🚀
MIT License
2.16k stars 244 forks source link

chore(nestjs-graphql-request): bump graphql-request packages v7.0.1 #739

Closed GauthierD- closed 3 weeks ago

GauthierD- commented 1 month ago

The package nestjs-graphql-request utilizes graphql-request, and a new version (v7.0.1) has been released. As a result of this major version update (v6 -> v7), I am also updating nestjs-graphql-request to v1.0.0.

Please be aware that this update includes breaking changes. The two primary changes are the discontinuation of support for CommonJS and the removal of the cross-fetch polyfill. A comprehensive list of the breaking changes can be found here:

https://github.com/jasonkuhrt/graphql-request/releases/tag/7.0.0

closes #738

GauthierD- commented 1 month ago

Dunno why the CI fail, if someone has an idea feel free to share

On my local machine: Screenshot 2024-05-21 at 7 37 38 PM Screenshot 2024-05-21 at 7 37 45 PM

underfisk commented 1 month ago

@GauthierD- Could you re-generate yarn.lock? It doesn't seem to be able to find graphql-request for some reason

GauthierD- commented 1 month ago

Hello @underfisk I can now reproduce this error, I guess it's related to that =/

TypeScript Setup
This package uses [package.exports] (https://www.typescriptlang.org/docs/handbook/modules/reference.html#packagejson-exports). Therefore if you are a > TypeScript user you must:

have your tsconfig.json moduleResolution set to ["bundler"](https://www.typescriptlang.org/docs/handbook/modules/reference.html#bundler) or ["node16"/"nodenext"](https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext-1).
Have your package.json type set to "module".

I'll try something but I'm not an expert of Lerna wish me luck 🍀

GauthierD- commented 1 month ago

I fixed the build but now the problem is related to jest (ts-jest) =/ I think I'll close this PR for now and if someone have time they can finish the job 👌