golf1052 / code-sync

Sync VSCode extensions using your favorite file synchronization service (OneDrive, Dropbox, Google Drive, etc.)
https://marketplace.visualstudio.com/items?itemName=golf1052.code-sync
MIT License
34 stars 3 forks source link

Cannot set external sync path with spaces escaped by backslash #29

Open runlevelsix opened 6 years ago

runlevelsix commented 6 years ago

If you are reporting an issue/bug please fill in your VSCode version, CodeSync version, and if you are on version 2.4.0 and above the CodeSync log from the CodeSync output channel. Thanks!

If you are requesting a feature feel free to clear this template.

VSCode version: 1.18.1

CodeSync version: 2.5.0

CodeSync log:

settings.ts
    2017-11-30T18:50:55.869Z - Creating settings with internal settings.json path and external extensions.json path: /Users/jc/.vscode/extensions/golf1052.code-sync-2.5.0/settings.json, extensions.json.
helpers.ts
    2017-11-30T18:50:58.804Z - Found code version: 1.18.1
929bacba01ef658b873545e26034d1a8067445e9
.
cs.ts
    2017-11-30T18:50:58.805Z - Checking settings
    2017-11-30T18:50:58.876Z - Could not find settings in /Users/jc/.vscode/extensions/golf1052.code-sync-2.5.0/settings.json. Creating...
    2017-11-30T18:51:01.170Z - Setting external extensions path as /Users/jc/OneDrive/Apps/code-sync/extensions.json.
    2017-11-30T18:51:01.171Z - CodeSync external sync directory isn't there?
    2017-11-30T18:51:01.171Z - Creating external sync path directory: /Users/jc/OneDrive/Apps/code-sync.
    2017-11-30T18:51:01.171Z - Done checking settings.
    2017-11-30T18:51:01.171Z - External sync directory: /Users/jc/OneDrive/Apps/code-sync
    2017-11-30T18:51:01.174Z - Importing settings
    2017-11-30T18:51:01.174Z - Failed to import settings. Could not find settings.json at /Users/jc/OneDrive/Apps/code-sync/settings.json. Giving up.
    2017-11-30T18:51:01.174Z - Importing keybindings
    2017-11-30T18:51:01.174Z - Failed to import keybindings. Could not find keybindings.json at /Users/jc/OneDrive/Apps/code-sync/keybindings.json. Giving up.
    2017-11-30T18:51:01.174Z - Importing snippets
    2017-11-30T18:51:01.175Z - Failed to import snippets. Could not find snippets directory at /Users/jc/OneDrive/Apps/code-sync/snippets. Giving up.
    2017-11-30T18:51:01.175Z - Importing extensions
    2017-11-30T18:51:01.175Z - Finished importing extensions.
    2017-11-30T18:53:20.941Z - Creating external sync path: /Volumes/GoogleDrive/My\ Drive/vscode
    2017-11-30T18:54:02.444Z - Creating external sync path: /Volumes/GoogleDrive/My\ Drive/vscode/code-sync
    2017-11-30T18:55:59.769Z - Creating external sync path: /Volumes/GoogleDrive/My\ Drive/vscode/code-sync
    2017-11-30T19:09:28.240Z - Creating external sync path: /Volumes/GoogleDrive/My\ Drive/vscode/code-sync

Issue: The last four entries are me trying to add the path /Volumes/GoogleDrive/My\ Drive/vscode/code-sync as the external sync path. However, it fails with an error ECANCELED: operation canceled, mkdir '/Volumes/GoogleDrive/My\ Drive'

Once I removed the forward slash escaping the space character in "My Drive", CodeSync was able to create the path and a sync happened when I quit VS Code.