search

golf1052 / code-sync

Sync VSCode extensions using your favorite file synchronization service (OneDrive, Dropbox, Google Drive, etc.)
https://marketplace.visualstudio.com/items?itemName=golf1052.code-sync
MIT License
34 stars 3 forks source link

Auto import blocks editing files - appears to be slow checking installed extensions #30

Closed wesmdemos closed 6 years ago

wesmdemos commented 6 years ago

VSCode version: 1.19.1 macOS CodeSync version: 2.5.0

Every time I open vscode, the auto import blocks editing files. The status bar reports "Importing keybindings" for 30+ seconds:

image

However, the output channel for code-sync (see below) shows other activity that's not reflected in the status bar and key presses happen after the import completes.

The problem appears to be checking installed extensions. It takes about 26 seconds to check 64 extensions that are already installed.

I don't mind a slow start on the first import or on importing some major changes like a new extension. But, it's not fun sitting through this every time I open vscode.

Is there a way to make the plugin non-blocking except when making changes?

Output:

cs.ts
    2017-12-23T00:33:31.935Z - Checking settings
    2017-12-23T00:33:31.954Z - Setting external extensions path as /masked/external/path/vscode/extensions.json.
    2017-12-23T00:33:31.954Z - Done checking settings.
    2017-12-23T00:33:31.954Z - External sync directory: /masked/external/path/vscode
    2017-12-23T00:33:31.962Z - Importing settings
local-settings.ts
    2017-12-23T00:33:31.965Z - Saving imported settings.
cs.ts
    2017-12-23T00:33:31.966Z - Finished importing settings.
    2017-12-23T00:33:31.966Z - Importing keybindings
    2017-12-23T00:33:32.285Z - Finished importing keybindings.
    2017-12-23T00:33:32.285Z - Importing snippets
    2017-12-23T00:33:32.294Z - Finished importing snippets.
    2017-12-23T00:33:32.294Z - Importing extensions
helpers.ts
    ... < truncated 64 Extensions that are already installed > ...
    2017-12-23T00:33:58.552Z - Extension was already installed.
cs.ts
    2017-12-23T00:33:58.552Z - Finished importing extensions.
golf1052 commented 6 years ago

I figured out how to set up the profiler today so I could see where the slowdown was happening but realized you reported the issue correctly in the ticket 🤦🏾‍♂️.

Added a check of installed extensions to only try and install extensions that are not being reported as installed. When testing, one time it marked one of my 17 installed packages as not installed (when it was) so that may be an issue with how VSCode reports what extensions are installed on startup. However my startup time is much faster.

I've released the change in 2.5.2. If you are still experiencing issues please report back. Thanks for the report!