search

golioth / docs

Creative Commons Attribution Share Alike 4.0 International
6 stars 11 forks source link

Board name for Circuit Dojo in mRF91 Quickstart #131

Closed vitprajzler closed 2 years ago

vitprajzler commented 2 years ago

The current Zephyr release has only two boards defined for the Circuit Dojo Feathers, circuitdojo_feather_nrf9160 and circuitdojo_feather_nrf9160ns.

The nRF91 quickstart guide lists circuitdojo_feather_nrf9160_ns as target, which does not exist. It should say one of the board names above.

szczys commented 2 years ago

nRF91 Quick Start overview page page directs user to hardware section. This should probably be updated to the Board Catalog section:

See the Hardware section for more devices that use the nRF91

https://docs.golioth.io/hardware/nrf91/quickstart

mniestroj commented 2 years ago

circuitdojo_feather_nrf9160_ns is the correct name, so docs are right in that case. However wrong NCS revision was specified, which is why circuitdojo_feather_nrf9160_ns was non-existing and circuitdojo_feather_nrf9160ns was. So after merging #139 and following quickstart for nRF91 Feather, everything should work.

vitprajzler commented 2 years ago

Changes in #139 fix this. Closing.

mniestroj commented 2 years ago

@vitprajzler FYI when #139 would be merged, then this issue would be closed automatically due to usage of "Fixes: " in PR description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword). So there is no need to do it manually.