search

golioth / golioth-firmware-sdk

Firmware SDK enabling any IoT device to connect to Golioth - the Universal Connector for IoT
https://golioth.io
Apache License 2.0
57 stars 11 forks source link

tests: hil: rpc: wait for RPC establishment before sending RPCs #499

Closed sam-golioth closed 4 months ago

sam-golioth commented 4 months ago

In the observation_repeat_restart test, we were waiting for the device to establish a connection to Golioth before the test script sends an RPC to the device. This creates a small window between when the device establishes a connection and when it establishes an observation on the RPC path where attempts to send an RPC will fail. Instead, we should wait for the device to report that is successfully established an observation before the test script attempts to send any RPCs to the device. This matches the behavior in other parts of the test script.

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit fa2a892):

https://golioth-firmware-sdk-doxygen-dev--pr499-rpc-hil-fix-ql4zo5lb.web.app

(expires Fri, 31 May 2024 14:43:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

sam-golioth commented 4 months ago

@szczys @mniestroj I added another commit with additional logging, please take another look

mniestroj commented 4 months ago

I added another commit with additional logging, please take another look

LGTM