golioth / golioth-firmware-sdk

Firmware SDK enabling any IoT device to connect to Golioth - the Universal Connector for IoT
https://golioth.io
Apache License 2.0
57 stars 11 forks source link

blockwise: remove retry_count from the context structure #514

Closed sam-golioth closed 3 months ago

sam-golioth commented 3 months ago

There's no need to store the retry count in the blockwise transfer context structure. We can store it locally on the stack, which is both more efficient and easier to read.

Not that we aren't using the retry count yet, but we will as part of error handling.

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit e46724b):

https://golioth-firmware-sdk-doxygen-dev--pr514-blockwise-tran-ez3nm5b5.web.app

(expires Thu, 13 Jun 2024 18:19:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578