search

golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
67 stars 19 forks source link

[CoAP rework] move lightdb, lightdb_stream, rpc and settings to 'coap_req' #269

Closed mniestroj closed 1 year ago

mniestroj commented 2 years ago

Closes: #269

mniestroj commented 2 years ago

@ncmiller @szczys @ChrisGammell This contains new high-level API proposal for all the services (besides logging). All samples updated. Any comments are welcome. The underneath mechanism (coap_req) still needs some love and better testing/error handling. But it will mostly stay as is.

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit dba5ff2):

https://golioth-zephyr-sdk-doxygen-dev--pr269-golioth-lightdb-82kdjnux.web.app

(expires Fri, 14 Oct 2022 23:42:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

mniestroj commented 2 years ago

It seems that CI is not running since the base branch is not main. You could defer CI checks until after this merges to golioth-dfu, or we could update the workflows to run on any PR, regardless of base branch. Which do you think is best here?

I think that building PRs to any branches make sense.

ncmiller commented 2 years ago

It seems that CI is not running since the base branch is not main. You could defer CI checks until after this merges to golioth-dfu, or we could update the workflows to run on any PR, regardless of base branch. Which do you think is best here?

I think that building PRs to any branches make sense.

Handling that in https://github.com/golioth/golioth-zephyr-sdk/pull/279.