golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
68 stars 19 forks source link

[CoAP rework] coap_req: introduce new helper module #270

Closed mniestroj closed 2 years ago

mniestroj commented 2 years ago

Introduce new helper module, which will handle most low-level CoAP specific tasks like:

Add golioth_prepare_poll() function will allow to get file descriptor and next timeout value, so those values can be passed to subsequent poll() system call. This is used by system_client.c implementation, but the idea is to split it into application specific custom "system client" implementation.

TODO:

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 6ced72c):

https://golioth-zephyr-sdk-doxygen-dev--pr270-coap-req-5mupsuoz.web.app

(expires Fri, 14 Oct 2022 23:25:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

ncmiller commented 2 years ago

to be tested with nRF91 modem sockets, where wakeup might not work (due to no suport of waking up from poll())

Is this still a TODO?

mniestroj commented 2 years ago

to be tested with nRF91 modem sockets, where wakeup might not work (due to no suport of waking up from poll())

Is this still a TODO?

Tested. Unfortunately poll() does not support being interrupted with offloaded sockets (which nRF91 sockets are). Created https://golioth.atlassian.net/browse/DSDK-390 to address that.