golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
67 stars 19 forks source link

Add mimxrt1060_evkb to all samples along with ethernet support #271

Closed szczys closed 2 years ago

szczys commented 2 years ago

This PR follows the example of samples/common/wifi, adding an Ethernet option to handle the needed DHCP operations for the connection type.

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 44a5671):

https://golioth-zephyr-sdk-doxygen-dev--pr271-szczys-nxp1060-e-14ijassi.web.app

(expires Tue, 13 Sep 2022 19:34:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

szczys commented 2 years ago

After the changes this builds for the mimxrt1060_evkb, but not for other configurations that don't have CONFIG_NET_DHCPV4 selected. I'll be a little more clever and push some changes when I figure this out.

mniestroj commented 2 years ago

I guess you should include zephyr/net/dhcpv4.h to fix this build issue.

mniestroj commented 2 years ago

@szczys Nit: for consistency please use lowercase samples in commit messages, so that grepping git history with something like git log --grep=samples: would still be possible (with your commits included).

szczys commented 2 years ago

I added https://github.com/golioth/golioth-zephyr-sdk/pull/271/commits/44a567106135972c070af681f8da3bd8b6b084ce to this PR to change the way we call network helper functions from samples:

One question I have is whether I actually need to make the CONFIG_GOLIOTH_SAMPLE_DHCP_START dependent on NET_L2_ETHERNET. I need it for this board (and other Ethernet connections) but I don't know if there's a future use case for DHCP when ethernet will not be selected.