golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
66 stars 19 forks source link

samples: pytest: improvements and fixes #311

Closed mniestroj closed 1 year ago

mniestroj commented 1 year ago

All samples but DFU are not handlng properly the case when --initial-timeout is not provided (which is true for all platforms other than nRF91). request.config.getoption('--initial-timeout', DEFAULT_TIMEOUT) retured None, which means that None was passed to pexpect.expect() or pexpect.readline() methods. This was resulting in infinite timeouts, instead of default 30s timeouts.

Copy initial_timeout fixture from DFU's pytest script to all other samples' scripts.

Remove dead code in lightdb/observe pytest script.

Fix lightdb/get pytest script to handle counter values logged as hexdump. See commit message for details why this was not detected in CI (and why other bugs might be missed as well).

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 4d09438):

https://golioth-zephyr-sdk-doxygen-dev--pr311-pytest-improveme-nmd35i2e.web.app

(expires Tue, 25 Oct 2022 21:21:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49