golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
66 stars 19 forks source link

tests: lightdb: fix error handling and fix copy-paste error in log #327

Closed mniestroj closed 1 year ago

mniestroj commented 1 year ago

This test does not expect any counter, so remove this word from log message.

If there was an error during asynchronous (callback-based) request, then such error was not propagated to struct async_data structure, but instead it was still set to 0, just like the API would be successful. Later, test would discover a problem anyway, as received data would not match with expected one. However, it is better to propagate error and not rely on data comparison.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 0e2a1af):

https://golioth-zephyr-sdk-doxygen-dev--pr327-tests-lightdb-fi-0xt7mcc9.web.app

(expires Thu, 15 Dec 2022 22:24:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49