golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
66 stars 19 forks source link

golioth: fix zsock_setsockopt(..., TLS_HOSTNAME, ...) API use #348

Closed mniestroj closed 1 year ago

mniestroj commented 1 year ago

zsock_setsockopt() expects to receive NULL terminated string and length of the string including NULL termination. Adjust code to follow that.

See Zephyr upstream commit 4234e801b544 ("net: sockets: Fix TLS_HOSTNAME option length inconsistency") for details.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit aaa91be):

https://golioth-zephyr-sdk-doxygen-dev--pr348-zsock-setsockopt-5qd3gbrb.web.app

(expires Tue, 14 Mar 2023 12:53:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

mniestroj commented 1 year ago
aaa91be5860fc66dc10aad6d36b9daa6b44e1325:9: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '4234e801b544', maybe rebased or not pulled?

is a false-positive in this context. This commit sha1 is from Zephyr upstream, not from this repo. It is explicitly stated so.