golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
66 stars 19 forks source link

west-zephyr: import all Zephyr modules #351

Closed mniestroj closed 1 year ago

mniestroj commented 1 year ago

In case of west-zephyr.yml there is a name-allowlist filter, while in case of west-ncs.yml there is no such filter. This makes filtering logic inconsistent across Zephyr vanilla vs NCS.

Limiting repositories has a major flaw when user wants to utilize a generic library such as picolibc, which is filtered out. In that case it is needed to add that repository to downstream manifest or temporarily modify west-zephyr.yml in order to test some non-standard configuration with SDK samples.

Let's be consistent about Zephyr modules filtering and always import all the modules in west-zephyr.yml, just like it happens with west-ncs.yml.

Since limiting west-zephyr.yml was mainly a clone time improvement, noticeable in CI, add .ci-west-zephyr.yml which will limit repositories just for being run in CI.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit cbb3972):

https://golioth-zephyr-sdk-doxygen-dev--pr351-manifest-drop-al-9zlp3zlr.web.app

(expires Fri, 24 Mar 2023 14:19:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49