golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
65 stars 20 forks source link

Add DFU testing workflow #369

Closed szczys closed 1 year ago

szczys commented 1 year ago

This PR adds a workflow to test samples/dfu using Twister on the nRF52840dk via a self-hosted runner.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 75c0818):

https://golioth-zephyr-sdk-doxygen-dev--pr369-szczys-add-dfu-w-ku9520qq.web.app

(expires Mon, 15 May 2023 16:41:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

szczys commented 1 year ago

This workflow is fully tested and ready for review.

The one outstanding issue is that during testing I was receiving false-negatives from Twister. However, when testing against the dev server today, I did not encounter that. I've created a separate issue to track the behavior.

szczys commented 1 year ago

I added three commits to this PR that fix two issues that were causing this workflow to fail:

  1. added golioth rollback '*' command which will rollback any existing releases before starting Twister
  2. workflow adds a delay to the top of main() so logs are not missed during test.

The second point is not a permanent fix, but it will be enough for us to reliably run this test while a permanent fix is found.

PS- this action is a successful test-run of this workflow