search

golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
67 stars 19 forks source link

.github: test_nrf52840dk/9160dk use subdirectory #379

Closed szczys closed 1 year ago

szczys commented 1 year ago

When running workflows on self-hosted runners, checkout and working-directory should use a subdirectory so that different workflows don't collide.

Generally, this means Twister-based workflows can use the same subdirectory to share common files. For example, modules generally don't differ from one test to the next, and if there is a different, the west update step will correct for it.

However, tests that don't use Twister (specifically, the ones that don't use a Docker container) need different user permissions on the files. Using subdirectories keeps these separate while still minimizing the amount of cloned data on subsequent runs.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit e3e75be):

https://golioth-zephyr-sdk-doxygen-dev--pr379-szczys-test-nrf5-o42xyyqq.web.app

(expires Thu, 11 May 2023 15:49:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

szczys commented 1 year ago

Sorry for all the noise on this PR. I saw that overnight the nRF9160dk test failed for the same reason so I added a commit to make the changes there as well.

I had a few false-starts in how to reference a previous commit in a subsequent commit message so checkpatch set me straight. (I'm unsure of why my local checkpatch didn't catch the issue?)

This is now ready for review. Thanks!