golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
65 stars 20 forks source link

bump NCS to 2.4.0 #393

Closed mniestroj closed 1 year ago

mniestroj commented 1 year ago

Newest NCS version is desired to pull zcbor API changes.

Satisfy build-time check of MBEDTLS_PK_C, which requires either ECP or RSA to be enabled.

Select RSA for cert-based auth, as it is no longer selected by default.

Use CONFIG_LTE_CONNECTIVITY instead of CONFIG_LTE_AUTO_INIT_AND_CONNECT, as the latter is deprecated. Select IPv6 (with certains options disabled), as it is a requirement of CONFIG_LTE_CONNECTIVITY.

NCS' west manifest now includes qcbor module. Rename our qcbor to golioth-qcbor, so that name does not conflict.

Fixes: https://github.com/golioth/firmware-issue-tracker/issues/141

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 356e8c1):

https://golioth-zephyr-sdk-doxygen-dev--pr393-bump-ncs-3-5rnk4wab.web.app

(expires Tue, 20 Jun 2023 10:06:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

sam-golioth commented 1 year ago

Select IPv6 (with certains options disabled)

Were we using IPv6 before? What's the RAM/ROM impact of enabling this?

mniestroj commented 1 year ago

Select IPv6 (with certains options disabled)

Were we using IPv6 before? What's the RAM/ROM impact of enabling this?

We didn't use and still don't use IPv6. Enabling it is required to satisfy NCS broken Kconfig dependencies. I haven't checked what is the RAM/ROM impact, as there is no way to keep IPv6 disabled with new NCS version (so can't really isolate how IPv6 alone affects application footprint).