search

golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
67 stars 19 forks source link

samples: Use EXTRA_CONF_FILE instead of OVERLAY_CONFIG #420

Closed sam-golioth closed 1 year ago

sam-golioth commented 1 year ago

OVERLAY_CONFIG was deprecated in favor of EXTRA_CONF_FILE in 6a98c198d8f3

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit fbd2b51):

https://golioth-zephyr-sdk-doxygen-dev--pr420-use-extra-conf-f-jnuhhoyl.web.app

(expires Mon, 14 Aug 2023 20:22:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

sam-golioth commented 1 year ago

@mniestroj One more for v0.7.0. Feel free to merge this if it looks good to you and you're working on the release before I get online Monday.

sam-golioth commented 1 year ago

Changes look good, but what is 6a98c198d8f3 referenced in commit body? I don't think it is a valid commit sha1, if that is what it was supposed to be.

Whoops. It was supposed to be Zephyr upstream, but I think I must have taken the commit from the PR branch instead of main. It should be 3a345682ba81. I'll update the commit message with the right SHA1 and to indicate that it's from Zephyr, not this repo.