golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
65 stars 20 forks source link

fw: inform user when no firmware release found #423

Closed szczys closed 11 months ago

szczys commented 11 months ago

When no firmware release is available for a device, Golioth will return a zero-length CoAP map (0xa0). When this value is received, show a warning message that "No fw release available", instead of the default "Failed to decode desired map"

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit 2cd47dd):

https://golioth-zephyr-sdk-doxygen-dev--pr423-szczys-fw-no-rel-vwntikqq.web.app

(expires Wed, 16 Aug 2023 23:42:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

mniestroj commented 11 months ago

Good catch! It is definitely a regression. @szczys What do you think about #424 ? It would basically bring the behavior we have previously when QCBOR was used.

szczys commented 11 months ago

Yes, #424 looks like a better solution!