search

golioth / golioth-zephyr-sdk

Golioth SDK For Zephyr
https://www.golioth.io
Apache License 2.0
65 stars 20 forks source link

zcbor: backport zcbor_any_skip() for zcbor < 0.7.0 #426

Closed mniestroj closed 11 months ago

mniestroj commented 11 months ago

Backport fixed zcbor_any_skip() from zcbor 0.7.0.

This fixes 'samples/rpc/' when used with NCS, which pulls zcbor in version 0.6.0.

Fixes: https://github.com/golioth/firmware-issue-tracker/issues/197

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit 9b9b5b8):

https://golioth-zephyr-sdk-doxygen-dev--pr426-zcbor-backport-z-0klduoar.web.app

(expires Fri, 18 Aug 2023 13:49:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

mniestroj commented 11 months ago

All checkpatch errors are related to code copy-pasted from zcbor library. Since this is a temporary solution (until there is new release of NCS), IMO we should just ignore those for the sake of this PR.

sam-golioth commented 11 months ago

All checkpatch errors are related to code copy-pasted from zcbor library. Since this is a temporary solution (until there is new release of NCS), IMO we should just ignore those for the sake of this PR.

Especially because it's contained to one file.