Implement GOLIOTH_SAMPLE_FW_VERSION

szczys commented 9 months ago

This implements the GOLIOTH_SAMPLE_FW_VERSION symbol for setting the firmware version in the prj.conf file. This matches what we are doing in the Firmware SDK.

Considerations

This symbol makes the versioning process the same for both Zephyr and NCS
Firmware version can still be overriden at build time using -DCONFIG_GOLIOTH_SAMPLE_FW_VERSION=\"1.2.4\"
I have a Docs PR coming to match these changes

I tested the DFU sample with these changes on the following boards:

nRF9160dk
nRF52840 + ESP32
esp32_devkitc_wroom

Notable

I don't think this will affect the twister testing. I looked at the approach in the pytest files and it seems that the CONFIG_MCUBOOT_IMAGE_VERSION is being patched directly once the .config file is already generated. However, I have not run the Twister test on these changes.

github-actions[bot] commented 9 months ago

Visit the preview URL for this PR (updated for commit 24addec):

https://golioth-zephyr-sdk-doxygen-dev--pr435-szczys-implement-v4811whw.web.app

_{(expires Fri, 13 Oct 2023 21:23:52 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: a389eefadf4b4b68a539327b3459dd66c142cf49}

szczys commented 8 months ago

Since there are already 2 ways (see above) how (application) version can be set, I don't see good enough reason to introduce another way.

Okay, sounds good.

golioth / golioth-zephyr-sdk

Implement GOLIOTH_SAMPLE_FW_VERSION #435

Considerations

Notable