search

golioth / grafana-websocket-plugin

Apache License 2.0
32 stars 13 forks source link

Switch to the Grafana "standard" URL/HOST key name #30

Closed mountainash closed 1 year ago

mountainash commented 1 year ago

Closes #22

Allows the "top-level" use of the standard configuration key url:

mountainash commented 1 year ago

In the future the ConfigEditor.tsx <FormField should be replaced by something like 

      <DataSourceHttpSettings
        defaultUrl='wss://api.domain.io/v1/ws/'
        dataSourceConfig={options}
        onChange={onOptionsChange}

        showForwardOAuthIdentityOption={false}
        sigV4AuthToggleEnabled={false}
      />

But to do this it needs to handle a lot more connection options.

miguel91it commented 1 year ago

The plugin's backend code (go), looks fine. I cannot test it right now, but @chireia is taking care of the details with this PR.

Just make sure to build all the plugin, including the backend part, when testing it.

chireia commented 1 year ago

After a bit of digging I finally figured out how to properly use Grafana's provisioning (which was new to me). Your PR looks good to me. I'll be merging and deploying a new version to Grafana Cloud ASAP.

Thanks for your collaboration, Mr. @mountainash, you were the first 🥇🎉