Closure of inactive sessions not correctly handled

golistic / pxmysql

Go MySQL driver using X Protocol

MIT License

14 stars 0 forks source link

Closure of inactive sessions not correctly handled #22

Closed geertjanvdk closed 1 year ago

geertjanvdk commented 1 year ago

Currently, when the MySQL server (X Plugin) closes inactive sessions (after mysqlx_wait_timeout seconds), an incorrect error is returned:

failed unmarshalling server message type NOTICE (proto: required field Mysqlx.Notice.Warning.code not set)

This is itself a bug, as we would actually expect an EOF.

geertjanvdk commented 1 year ago

The problem with the required field is not set, is actually something we need to address in protobuf. We should AllowPartial unmarshalling option.