Closed golles closed 1 year ago
Base: 16.89% // Head: 73.86% // Increases project coverage by +56.96%
:tada:
Coverage data is based on head (
bfbe837
) compared to base (cbc618f
). Patch coverage: 52.41% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Great work! You can consider moving kampstrup.py to its own package and publish it to PyPI even. This way others can use it even more easily. It also keeps the home assistant parts (this repo) and the kampstrup interfacing separate.
Also, parentheses are only needed when catching multiple exception types. E.g., you can omit the parentheses on this line: https://github.com/golles/ha-kamstrup_403/pull/56/files#diff-b42daff407aa09858d366cd76d1042a12e82de32c92ea02115b6e6dd8393bae1R141
Great work! You can consider moving kampstrup.py to its own package and publish it to PyPI even. This way others can use it even more easily. It also keeps the home assistant parts (this repo) and the kampstrup interfacing separate.
I have thought about it, and I'm not entirely sure if I want to take public ownership of it, also because it's not really my code. But with the change I made in this PR, I agree it's pretty standalone. I'll give it another thought...
Also, parentheses are only needed when catching multiple exception types. E.g., you can omit the parentheses on this line: https://github.com/golles/ha-kamstrup_403/pull/56/files#diff-b42daff407aa09858d366cd76d1042a12e82de32c92ea02115b6e6dd8393bae1R141
Thanks, I found a few more as well, fixed in 8192f0d96c3025b5ff06153889a73482ccf64bdd
I have thought about it, and I'm not entirely sure if I want to take public ownership of it, also because it's not really my code. But with the change I made in this PR, I agree it's pretty standalone. I'll give it another thought...
Perhaps asking @bsdphk directly helps, maybe he can give his opinion?
kamstrup.py
to its own modulekamstrup.py
and add typings@adabrandt for your code suggestion in https://github.com/bsdphk/PyKamstrup/pull/6