golles / ha-kamstrup_403

Custom component that integrates the Kamstrup 403 heating system into Home Assistant. This component does also support a few other heating systems
MIT License
72 stars 12 forks source link

Entity names should be user-friendly #76

Closed golles closed 1 year ago

golles commented 1 year ago

Did you read the instructions?

The request

At the moment the entity names aren't very user-friendly.

Examples (draft): HourCounter -> Hour counter Temp1 -> Incoming temperature Temp2 -> Outgoing temperature MaxFlowDate_M -> Max flow date (month) MaxFlowDate_Y -> Max flow date (year)

The best practise is to get the names from the manual, https://www.kamstrup.com/en-en/heat-solutions/meters-devices/meters/multical-403/documents

Additional information

At the moment the entity id is computed from its name, a simple rename will result in a new entity making the old one unavailable. A migration should be in place to deal with this for existing users, or the logic for name/id should be decoupled.

Another thing to take into consideration is translations (at least English en Dutch, others can be added by the community)

HAEdwin commented 1 year ago

This public source helps to specify the correct names: https://www.askom.pl/WebHelp/Asix_Evo_10/EN/Communication_Drivers_HTML5/index.htm#t=Kmp.htm

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 5 days with no activity.