golles / ha-kamstrup_403

Custom component that integrates the Kamstrup 403 heating system into Home Assistant. This component does also support a few other heating systems
MIT License
70 stars 10 forks source link

Added support for Multical 402 additional Water meters #78

Closed AverageJoe89 closed 1 year ago

AverageJoe89 commented 1 year ago

Support for additional water metters connected to Input A&B (VA, VB) on Multical 402 According to Multical 402 manual

image

and protocol reference for Multical 801

Up to two additional water meters (eg. for cold water) can be connected to Multical 402 and read over IR interface, those are stored in registries 84 and 85.

In my example, no.1 has cold water meter, no. 2 is disconnected.

image

Tested with Multical 402 Home Assistant 2023.2.5 Supervisor 2023.01.1 Operating System 9.5 Frontend 20230202.0 - latest

golles commented 1 year ago

Thank you for your contribution, I've added a few comments. If you can address those, I'm happy to accept this PR!

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.76% // Head: 75.76% // No change to project coverage :thumbsup:

Coverage data is based on head (b94c145) compared to base (24e0e71). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ======================================= Coverage 75.76% 75.76% ======================================= Files 7 7 Lines 359 359 ======================================= Hits 272 272 Misses 87 87 ``` | [Impacted Files](https://codecov.io/gh/golles/ha-kamstrup_403/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander) | Coverage Δ | | |---|---|---| | [custom\_components/kamstrup\_403/sensor.py](https://codecov.io/gh/golles/ha-kamstrup_403/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL3NlbnNvci5weQ==) | `94.28% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

AverageJoe89 commented 1 year ago

Thanks, I will take a look on that.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] commented 1 year ago

This PR was closed because it has been stalled for 10 days with no activity.