golles / ha-kamstrup_403

Custom component that integrates the Kamstrup 403 heating system into Home Assistant. This component does also support a few other heating systems
MIT License
70 stars 10 forks source link

Spring improvements #91

Closed golles closed 1 year ago

golles commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 75.58% and project coverage change: -16.39 :warning:

Comparison is base (9f3997d) 75.69% compared to head (a9d5420) 59.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## =========================================== - Coverage 75.69% 59.31% -16.39% =========================================== Files 7 8 +1 Lines 358 349 -9 =========================================== - Hits 271 207 -64 - Misses 87 142 +55 ``` | [Impacted Files](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander) | Coverage Δ | | |---|---|---| | [custom\_components/kamstrup\_403/const.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL2NvbnN0LnB5) | `100.00% <ø> (ø)` | | | [custom\_components/kamstrup\_403/diagnostics.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL2RpYWdub3N0aWNzLnB5) | `0.00% <0.00%> (ø)` | | | [custom\_components/kamstrup\_403/coordinator.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL2Nvb3JkaW5hdG9yLnB5) | `67.34% <67.34%> (ø)` | | | [custom\_components/kamstrup\_403/config\_flow.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL2NvbmZpZ19mbG93LnB5) | `92.10% <82.35%> (-3.55%)` | :arrow_down: | | [custom\_components/kamstrup\_403/\_\_init\_\_.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL19faW5pdF9fLnB5) | `100.00% <100.00%> (+13.79%)` | :arrow_up: | | [...tom\_components/kamstrup\_403/pykamstrup/kamstrup.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL3B5a2Ftc3RydXAva2Ftc3RydXAucHk=) | `14.28% <100.00%> (-38.35%)` | :arrow_down: | | [custom\_components/kamstrup\_403/sensor.py](https://app.codecov.io/gh/golles/ha-kamstrup_403/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sander#diff-Y3VzdG9tX2NvbXBvbmVudHMva2Ftc3RydXBfNDAzL3NlbnNvci5weQ==) | `97.14% <100.00%> (+2.85%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

golles commented 1 year ago

The drop in test coverage isn't satisfying and will be improved later. This PR will be merged as this will unblock #86 #88 and #90