gollum / rugged_adapter

Adapter to make gollum use Rugged (libgit2) at the backend.
MIT License
36 stars 27 forks source link

Force diff encoding to UTF-8. #1

Closed LEW21 closed 9 years ago

LEW21 commented 9 years ago

Grit always returns strings tagged as UTF-8, but Rugged returns them as ASCII-8BIT. Gollum assumes UTF-8, and without any encoding changes concatenates the diff lines with UTF-8-encoded strings, which leads to an error if other strings contain non-ASCII characters.

dometto commented 9 years ago

Thanks for the catch and the fix!