Closed jhominal closed 8 years ago
Now, these three should be separate issues, but I will confess that I did not feel like making two issue tickets for what,
No problem!
Many thanks again for scrutinizing gollum and the adapters. I worked on too much of this with too little time to get proper reviews, so it's great to get some now.
Excellent. Thanks @jhominal for all your work on this!
There are three logical changes in this pull request:
.gitignore
file was added, to ignoreGemfile.lock
andcoverage
(same asgrit_adapter
);:committer
information is set, to the same information as:author
- closes #11;Index#get_parents
method modified theparents
argument - but, in the use that is made byGollum::Committer
, theparents
array would be modified to contain an array ofRugged::Commit
objects instead ofGollum::Git::Commit
objects - that seemed weird and undesirable to me;Now, these three should be separate issues, but I will confess that I did not feel like making two issue tickets for what, to me, feel like obvious improvements. If you feel that there is matter for a debate, feel free to tell me and I will open a separate issue, and amend this PR as necessary.