Closed JianleiZhang closed 5 years ago
file name has UTF8 character
http://192.168.2.188:4567/create/User/Jianlei%20Zhang/%E4%BA%91%E7%AD%BE%E5%88%B0 -> /javascript/editor/langs/markdown.js?_=1484813762714
[2017-01-19 16:19:21] ERROR URI::InvalidURIError: bad URI(is not URI?): http://192.168.2.188:4567/User/Jianlei Zhang/%E4%BA%91%E7%AD%BE%E5%88%B0
/usr/local/lib/ruby/2.4.0/uri/rfc3986_parser.rb:67:in `split'
/usr/local/lib/ruby/2.4.0/uri/rfc3986_parser.rb:73:in `parse'
/usr/local/lib/ruby/2.4.0/uri/rfc3986_parser.rb:117:in `convert_to_uri'
/usr/local/lib/ruby/2.4.0/uri/generic.rb:1099:in `merge'
/usr/local/lib/ruby/2.4.0/webrick/httpresponse.rb:277:in `setup_header'
/usr/local/bundle/gems/rack-1.6.5/lib/rack/handler/webrick.rb:16:in `setup_header'
/usr/local/lib/ruby/2.4.0/webrick/httpresponse.rb:207:in `send_response'
/usr/local/lib/ruby/2.4.0/webrick/httpserver.rb:112:in `run'
/usr/local/lib/ruby/2.4.0/webrick/server.rb:290:in `block in start_thread'
192.168.2.189 - - [19/Jan/2017:16:19:21 UTC] "POST /create HTTP/1.1" 303 0
http://192.168.2.188:4567/create/User/Jianlei%20Zhang/%E4%BA%91%E7%AD%BE%E5%88%B0 -> /create
Thanks for the bug report. We need a uniform way of handling file encoding to prevent a bunch of encoding related bugs like this one.
@JianleiZhang can you see if this is fixed when using the 5.x
branch of gollum
? We've made improvements to UTF8 handling.
This is resolved in 5.x
and the latest adapter.
Dockerfile:
when the directory name has UTF8 character,gollum has error: