search

gollum / rugged_adapter

Adapter to make gollum use Rugged (libgit2) at the backend.
MIT License
36 stars 27 forks source link

Rename Blob#is_symlink #58

Open dometto opened 1 year ago

dometto commented 1 year ago

The RJGit version is called #is_symlink?, which is more idiomatic. This should be added to the adapter specs, too.

dometto commented 1 year ago

Sorry, this was based on a confusion: the methods in both adapters have the same name. But we could make it more idiomatic by renaming to #is_symlink?, and add it to the adapter specs.

bartkamphorst commented 1 year ago

Should we introduce it as an alias?

dometto commented 1 year ago

Sure!