gollum / rugged_adapter

Adapter to make gollum use Rugged (libgit2) at the backend.
MIT License
36 stars 27 forks source link

Searching generates false-positives #7

Closed nlowe closed 9 years ago

nlowe commented 9 years ago

Searching for a keyword while using the rugged adapter sometimes generates false positives. For example, in a private wiki consisting of 150+ pages, searching for citrix returned the following results:

Notice that the few results are uploaded screenshots and are included as expected. Due to a file encoding issue in my environment, some of the expected results were NOT returned because the search term was not listed in the filename exactly as searched. For example, none of these pages were included in the search result:

image

However, towards the end of the screenshot, you will notice that pages that do not mention the search term nor contain the search term in their name are returned, even though gollum thinks there were 0 matches (the 0 in parenthesis next to the page title). A complete list of false positives can be seen below:

image

dometto commented 9 years ago

@techwiz24 this should be fixed in HEAD

nlowe commented 9 years ago

@dometto Seems to be the case, thanks! Any idea when the next version will be cut?