search

golosio / xrmc

17 stars 10 forks source link

MetaImageHeader file for a single raw image #47

Closed MichaelColonel closed 4 years ago

MichaelColonel commented 4 years ago

Dear developers,

Meta header information allows easier loading of raw image for further processing (e.g. in ITK), not just raw import in ImageJ. It could be useful for somebody.

golosio commented 4 years ago

Dear Michael, the use of the header is optional or mandatory? Will it be still possible to produce raw images without header as output?

MichaelColonel commented 4 years ago

Optional. The MetaImage header file didn't modify the original raw data. This PR creates additional .mhd text file, original raw data can be used as before.

tschoonj commented 4 years ago

Generating these files should be optional in my opinion. Can you add a flag for this?

Thanks!

MichaelColonel commented 4 years ago

Greetings,

Do you mean like AsciiFlag or HeaderFlag? I will try.

https://github.com/golosio/xrmc/blob/725512d7b70167a3aede2d50a7dcec4394db5eee/src/detector/xrmc_detector.h#L79-#lL80

tschoonj commented 4 years ago

Something like that would indeed be great. Thanks!

tschoonj commented 4 years ago

Thanks @MichaelColonel ! That looks good.

@golosio do you have any further comments?

MichaelColonel commented 4 years ago

Should i squash commits in this PR into one commit?

tschoonj commented 4 years ago

As you wish...

MichaelColonel commented 4 years ago

Commits have been squashed into one.

tschoonj commented 4 years ago

Thanks for your contribution @MichaelColonel !