search

gomarkdown / markdown

markdown parser and HTML renderer for Go
Other
1.41k stars 173 forks source link

Parse headless table #178

Closed rubensayshi closed 3 years ago

rubensayshi commented 3 years ago

this will parse a table without a header row as well, for example:

---|---
 c | d
miekg commented 3 years ago

Would be nice to support GFM tables as well: https://github.github.com/gfm/#tables-extension- I think the changes would also be minimal?

rubensayshi commented 3 years ago

sure, but I don't see anything in the GFM spec that you haven't already implemented, what are you referring to which could be added?

do you mean "If there are no rows in the body, no is generated in HTML output:"?

miekg commented 3 years ago

[ Quoting notifications@github.com in "Re: [gomarkdown/markdown] Parse hea..." ]

sure, but I don't see anything in the GFM spec that you haven't already implemented, what are you referring to which could be added?

apart from tables I don't think there is much difference? (admittently I didn't look too deeply into it)

miekg commented 3 years ago

[ Quoting notifications@github.com in "[gomarkdown/markdown] Parse headles..." ]

this will parse a table without a header row as well, for example:

---|--- c | d

/lgtm

rubensayshi commented 3 years ago

ye I think you're already supporting the GFM table syntax perfectly? most markdown flavors seem to use the same syntax for tables :)

kjk commented 3 years ago

Thanks!