search

gomarkdown / markdown

markdown parser and HTML renderer for Go
Other
1.36k stars 171 forks source link

Solve issue #274 #275

Closed zyxkad closed 1 year ago

zyxkad commented 1 year ago
kjk commented 1 year ago

I would rather not add more options.

Will it work (i.e. will all the tests pass) without SingleDashSep option i.e. always act as if it was true?

zyxkad commented 1 year ago

Will it work (i.e. will all the tests pass) without SingleDashSep option i.e. always act as if it was true?

Yeah, all the tests you have were passed, and it's completely backward compatible.

kjk commented 1 year ago

That's great. Could you update the PR to remove the option?

zyxkad commented 1 year ago

That's great. Could you update the PR to remove the option?

I'm sorry. I thought I misunderstood you. I didn't add a option, but I added the SingleDasgSep as a parser.Extensions

zyxkad commented 1 year ago

Will it work (i.e. will all the tests pass) without SingleDashSep option i.e. always act as if it was true?

If you are asking #274 will pass without the flag, that's not true, because I make it backward compatible for someone who want show a single dash in their table. Which means, if some one want render table like #274, they must add the flag.

But if you want make it as a break change, I can remove the option and make it always parse the table.

kjk commented 1 year ago

Have to think more about it but I think it's fine to change behavior.

This seems to be how GitHub tables work so mHave to think more about it but I think it's fine to change behavior.

This seems to be how GitHub tables work so most implementations that parse tables, parse it this way.ost implementations that parse tables, parse it this way.

kjk commented 1 year ago

decided to change behavior without additional options.

Per babelmark all parsers that parse tables have this behavior.