search

gomarz / SS-armaa

starsector mod. Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International license.
6 stars 2 forks source link

[Crash] Attempts to auto-exit simulation after all friendly ships are destroyed (with none left to deploy), causing crash to desktop #65

Open nissa-seru opened 1 month ago

nissa-seru commented 1 month ago

Vanilla behavior: In a simulation (begun via ship refit screen), if all friendly ships are destroyed with none left to deploy, the simulation will continue to run until the player manually ends it via the Esc menu.

armaa behavior: In the above condition, the game attempts to auto-exit the simulation, causing a crash to desktop via NullPointerException.

Steps to repro:

  1. Enable LazyLib (2.8b), MagicLib (1.4.5) , and armaa (3.0.6.1) - current versions at the time of writing.
  2. Create a new game.
  3. Open ship refit screen, open simulation.
  4. Deploy all of the ships in your fleet; deploy enemy ships to destroy them.
  5. After all of your ships are destroyed, crash occurs.

Repro successful with additional mods enabled as well; minimal modset above selected for simplicity.

starsector.log

gomarz commented 1 month ago

Thanks for the steps to repro :) I think this is fixed now, but will test a bit more to confirm tomorrow