search

gomate-community / rageval

Evaluation tools for Retrieval-augmented Generation (RAG) methods.
Apache License 2.0
81 stars 9 forks source link

re-define the function of init_model in metric #37

Closed faneshion closed 4 months ago

faneshion commented 4 months ago

https://github.com/gomate-community/rageval/blob/46dc95aa3d933ee5e2b030c05191e748e5e9c92e/rageval/metrics/_context_recall.py#L29

Maybe we should remove the initialization of model out of the Metric class. As is in the follows:

def init_model(self, model):
    self.llm = model

@Wenshansilvia How do you feel about it?